On Mon, Jul 14, 2014 at 10:21:51PM +0200, Clemens Ladisch wrote: > Borislav Petkov wrote: > > On Mon, Jul 14, 2014 at 03:23:08PM -0500, Aravind Gopalakrishnan wrote: > >> + if (boot_cpu_data.x86 == 0x15 && boot_cpu_data.x86_model == 0x60) { > >> + pci_bus_write_config_dword(pdev->bus, PCI_DEVFN(0, 0), > >> + NB_SMU_IND_ADDR, IND_ADDR_OFFSET); > >> + pci_bus_read_config_dword(pdev->bus, PCI_DEVFN(0, 0), > >> + NB_SMU_IND_DATA, ®val); > > How do you prevent races with any other code that accesses some indirect > register? > I just wanted to ask exactly the same question. I think this will need locking.
> >> + > >> + } else > >> + pci_read_config_dword(pdev, REG_REPORTED_TEMPERATURE, ®val); > > Why the empty line? Also, use braces in both branches. > Agreed. Too bad the respective checkpatch warning was moved to --strict. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/