On Fri, Mar 11, 2005 at 04:23:21AM -0800, Christoph Lameter wrote:
 > This patch extracts all the operations on counters protected by the
 > page table lock (currently rss and anon_rss) into definitions in
 > include/linux/sched.h. All rss operations are performed through
 > the following three macros:
 > 
 > get_mm_counter(mm, member)           -> Obtain the value of a counter
 > set_mm_counter(mm, member, value)    -> Set the value of a counter
 > update_mm_counter(mm, member, value) -> Add a value to a counter

Splitting this last one into inc_mm_counter() and dec_mm_counter()
means you can kill off the last argument, and get some of the
readability back. As it stands, I think this patch adds a bunch
of obfuscation for no clear benefit.

                Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to