On Thu, 2014-07-17 at 11:16 +0200, Tom Gundersen wrote: > >> static struct wireless_dev *ath6kl_cfg80211_add_iface(struct wiphy *wiphy, > >> const char *name, > >> + unsigned char > >> name_assign_type, > > > > unsigned char for an enum is really odd. > > Hm, this was based on the addr_assign_type attribute, which also is an > unsigned char (and serves a very similar purpose). > > Out of interest, what would you have preferred (and why)?
Even if it eventually ends up being assigned to a u8 or something, it seems passing it around as an enum makes the interfaces better? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
