On 07/22/2014 12:51 PM, Aaro Koskinen wrote: > get_system_type() is not thread-safe on OCTEON. It uses static data, > also more dangerous issue is that it's calling cvmx_fuse_read_byte() > every time without any synchronization. Currently it's possible to get > processes stuck looping forever in kernel simply by launching multiple > readers of /proc/cpuinfo: > > (while true; do cat /proc/cpuinfo > /dev/null; done) & > (while true; do cat /proc/cpuinfo > /dev/null; done) & > ... > > Fix by initializing the system type string only once during the early > boot. > > Signed-off-by: Aaro Koskinen <aaro.koski...@nsn.com> > Cc: sta...@vger.kernel.org > --- > arch/mips/cavium-octeon/setup.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) >
It looks reasonable to me. Reviewed-by: Markos Chandras <markos.chand...@imgtec.com> -- markos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
