Hi, Yao Yuan wrote: > Hi, > > Thanks for your review. > > Lothar Waßmann wrote: > > Yuan Yao wrote: > > > Add dma support for i2c. This function depend on DMA driver. > > > You can turn on it by write both the dmas and dma-name properties in dts > > > node. > > > > > > Signed-off-by: Yuan Yao <yao.y...@freescale.com> > > > --- > > > drivers/i2c/busses/i2c-imx.c | 377 > [...] > > > + > > > +fail_rx: > > > + dma_release_channel(dma->chan_rx); > > > +fail_tx: > > > + dma_release_channel(dma->chan_tx); > > > +fail_al: > > > + devm_kfree(dev, dma); > > > > > No need for this one (that's the whole point of using devm_kzalloc())! > > > > When DMA request failed, I2C will switch to PIO mode. So if the failed reason > is just like DMA channel request failed. At this time the DMA should free by > devm_kfree(). Is it? > OK. I didn't notice that failing DMA support wasn't a showstopper for the whole driver. In this case I would remove the 'failed' from the messages inside i2c_imx_dma_request() to make them more benign looking and output them with dev_dbg(), so they can be en-/disabled with CONFIG_I2C_DEBUG_BUS.
What about returning -EPROBE_DEFER in appropriate cases (when there is a chance that the DMA driver will be probed later than the I2C driver)? Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | i...@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
