Hi Andrew I've taken your comment into account, yet for the PHY init comment, see my answer below.
Le 23 juil. 2014 à 16:14, Andrew Lunn <[email protected]> a écrit : > >>> + /* warning: you need both eth1 & 0 to be initialize for poweroff to >>> shutdown otherwise it reboots */ > > What do you mean by initialized? Driver loaded? Interface up? Well actually the PHY need to be initialized (at least 1 mII reg written), which from marvel LSP driver always occurs, while it doesn't with mainline PHY driver (drivers/net/phy/marvell.c), so the only simple way I found to have at least one PHY reg on both interface written is to have both eth up at OS config level. Probably the best option would be to have a reg-init = <reg offset value> on both phy dts definition but the current armada mii doesn't support this dts config... > >> This is a great first version > > I agree with Jason, well done. > Thanks ! > Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
