On Wed, Jul 23, 2014 at 11:20:27PM +0200, Rickard Strandqvist wrote:
> Variable was assigned a value that is never used.
> Now the variable is used, and the function returns if a call to
> uvesafb_exec() returns a error.
Because the only user of uvesafb_vbe_getpmi in uvesafb.c
don't check its return value, it should do the check indeed,
so maybe below change is better:
- if ((task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es < 0xc000) {
+ if (err || (task->t.regs.eax & 0xffff) != 0x4f || task->t.regs.es <
0xc000) {
par->pmi_setpal = par->ypan = 0;
}
Or we check uvesafb_vbe_getpmi's return value, then the code will looks like
below:
if (uvesafb_vbe_getpmi(task, par))
par->pmi_setpal = par->ypan = 0;
Add cc:pa...@ucw.cz, you should cc all the people who replied your patch
in later patch version.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
