On Mon, Mar 14, 2005 at 11:32:39AM -0800, Jesse Barnes wrote:
> The sal_console and sal_console_uart structures have a circular relationship
> since they both initialize member fields to pointers of one another. The
> current code forward declares sal_console_uart as extern so that sal_console
> can take its address, but gcc4 complains about this since the real definition
> of sal_console_uart is marked 'static'. This patch just removes the static
> qualifier from sal_console_uart to avoid the inconsistency. Does it look ok
> to you, Pat?
>...
> ===== drivers/serial/sn_console.c 1.12 vs edited =====
> --- 1.12/drivers/serial/sn_console.c 2005-03-07 20:41:31 -08:00
> +++ edited/drivers/serial/sn_console.c 2005-03-14 10:57:19 -08:00
> @@ -801,7 +801,7 @@
>
> #define SAL_CONSOLE &sal_console
>
> -static struct uart_driver sal_console_uart = {
> +struct uart_driver sal_console_uart = {
> .owner = THIS_MODULE,
> .driver_name = "sn_console",
> .dev_name = DEVICE_NAME,
Why can't you solve this without making sal_console_uart global?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
