On Sat, 12 Mar 2005 20:41:14 MST, Frank Sorenson said: > These patches look pretty good. A few comments (with a patch--tested on > my Inspiron 9200):
I tested your patch on top of Dmitry's on a Dell Latitude C840, seems to work. > - - Some of the Dell motherboards provide more than 1 temperature sensor. > ~ How about a generic i8k_get_temp function, and i8k_get_cpu_temp just > calls that with sensor 0. > > - - Also, I've added detection of the number of temperature sensors and > fans at init time. This way, we aren't hardcoded to 1 sensor and 2 > fans. I couldn't figure out how to set up the sysfs entries > dynamically, but that probably should happen too. According to your patch, the C840 has 2 temp sensors. I'll have to figure out what the second one is (prob either the GPU or the disk drive?)
pgp3OjiePzAAX.pgp
Description: PGP signature
