Hi Arnaldo, On Fri, 25 Jul 2014 10:27:05 -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jul 22, 2014 at 04:17:37PM +0300, Adrian Hunter escreveu: >> perf script was not displaying callchains if any selected >> event did not have PERF_SAMPLE_CALLCHAIN. Change this to >> disable callchains only if all selected events do not have >> PERF_SAMPLE_CALLCHAIN. > > I wonder if some other tool gets this wrong as well, report maybe? > > Perhaps we need to have this check in some perf_evlist method? > > Wonder how report/top, i.e. the hists browser will react with some > events having callchains while some don't, specially with this new > children stuff, Namhyung, can you please check that?
The children/cumulate stuff is enabled if a combined sample type contains PERF_SAMPLE_CALLCHAIN and works only a sample actually contains callchain. So I guess if some have it and some don't, events don't have callchain just prints real entries/samples with same children overhead value. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
