Hi!
> This patch adds a freezer call to the slow path in __alloc_pages. It
> thus avoids freezing failures in low memory situations. Like the other
> patches, it has been in Suspend2 for longer than I can remember.
This one seems wrong.
What if someone does
down(&some_lock_needed_during_suspend);
kmalloc()
? If you freeze him during that allocation, you'll deadlock later...
Pavel
> Signed-of-by: Nigel Cunningham <[EMAIL PROTECTED]>
>
> diff -ruNp 213-missing-refrigerator-calls-old/mm/page_alloc.c
> 213-missing-refrigerator-calls-new/mm/page_alloc.c
> --- 213-missing-refrigerator-calls-old/mm/page_alloc.c 2005-02-03
> 22:33:50.000000000 +1100
> +++ 213-missing-refrigerator-calls-new/mm/page_alloc.c 2005-03-16
> 09:01:28.000000000 +1100
> @@ -838,6 +838,7 @@ rebalance:
> do_retry = 1;
> }
> if (do_retry) {
> + try_to_freeze(0);
> blk_congestion_wait(WRITE, HZ/50);
> goto rebalance;
> }
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
