On Tue, Aug 05, 2014 at 04:07:48PM -0700, David Miller wrote: > From: Zoltan Kiss <[email protected]> > Date: Mon, 4 Aug 2014 16:20:56 +0100 > > > This series starts using carrier off as a way to purge packets when the > > guest is > > not able (or willing) to receive them. It is a much faster way to get rid of > > packets waiting for an overwhelmed guest. > > The first patch changes current netback code where it relies currently on > > netif_carrier_ok. > > The second turns off the carrier if the guest times out on a queue, and only > > turn it on again if that queue (or queues) resurrects. > > > > Signed-off-by: Zoltan Kiss <[email protected]> > > Signed-off-by: David Vrabel <[email protected]> > > Applied, but I have some reservations: >
Wow, this is fast. I appreciate your speed, but there's still outstanding issues in the series. Apart from some comments on maintainability, the biggest problem is that there's a bug in second patch that needs to be fixed; or I need to be proved wrong. We need to set aside some more time to get those questions answered. I don't think this series is suitable to go in as is. DaveM, could you please advise how to deal with this situation? Wei. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
