On Tue, Aug 05, 2014 at 09:25:53AM -0400, Eduardo Valentin wrote:
> > @@ -31,6 +32,10 @@
> >
> > #define MISC0 0x0150
> > #define MISC0_REFTOP_SELBIASOFF (1 << 3)
> > +#define MISC1 0x0160
> > +#define MISC1_IRQ_TEMPHIGH (1 << 29)
> > +#define MISC1_IRQ_TEMPLOW (1 << 28)
> > +#define MISC1_IRQ_TEMPPANIC (1 << 27)
>
> how about using
> +#define MISC1_IRQ_TEMPHIGH BIT(29)
> +#define MISC1_IRQ_TEMPLOW BIT(28)
> +#define MISC1_IRQ_TEMPPANIC BIT(27)
While I agree this is good, I think it's more important to keep the
style consistent for the file. We already have a number of (1 << x)
in the file.
...
> > @@ -66,6 +76,21 @@ enum imx_thermal_trip {
> > #define FACTOR1 15976
> > #define FACTOR2 4297157
> >
> > +#define TEMPMON_V1 1
> > +#define TEMPMON_V2 2
> > +
>
> where does the V1/V2 nomenclature come from? how about:
>
> +#define TEMPMON_IMX6Q 1
> +#define TEMPMON_IMX6SX 2
+1
If the V1/V2 nomenclature is not coming from hardware manual, we don't
want to use it, neither code nor binding doc.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
