On 08/06/14 at 03:18pm, Matt Fleming wrote: > On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote: > > > > Shouldn't we clear the bit here if we failed to enable runtime > > services for some reason? Other code may test the bit assuming that it > > signifies that runtime services have been enabled successfully, while > > this patch changes it to mean that we /intended/ to enable them, which > > is not quite the same thing. > > Yep, good catch. We need to do something similar for efi_runtime_init() > on x86 too.
The current efi_runtime_init() enables the bit after getting the efi callback phyaddr of SetVirtualAddressMap. Thinking more about it, since SetVirtualAddressMap() could fail somehow it seems better to set EFI_RUNTIME_SERIVCES bit only when enter virtual mode return EFI_SUCCESS. Does it make sense to you, Matt? Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
