sec_irq_init() can fail if it encounters unknown device type or on regmap_add_irq_chip() error. Add missing sec_irq_init() return value checking to sec_pmic_probe().
Tested on Insignal's Exynos4412 based Origen board. Cc: Krzysztof Kozlowski <[email protected]> Cc: Sangbeom Kim <[email protected]> Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]> Acked-by: Kyungmin Park <[email protected]> --- patch is against next-20140804 branch of linux-next kernel drivers/mfd/sec-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index dba7e2b..f498867 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -353,7 +353,9 @@ static int sec_pmic_probe(struct i2c_client *i2c, if (pdata && pdata->cfg_pmic_irq) pdata->cfg_pmic_irq(); - sec_irq_init(sec_pmic); + ret = sec_irq_init(sec_pmic); + if (ret) + return ret; pm_runtime_set_active(sec_pmic->dev); -- 1.8.2.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
