On pią, 2014-08-08 at 09:34 +0200, Krzysztof Kozlowski wrote: > On czw, 2014-08-07 at 18:48 +0200, Bartlomiej Zolnierkiewicz wrote: > > [ added missing linux-samsung-soc ML, sorry for the noise ] > > > > On Thursday, August 07, 2014 06:42:28 PM Bartlomiej Zolnierkiewicz wrote: > > > Add missing check for the case of device without irq specified > > > in sec_irq_exit() (please note that sec_irq_init() already > > > correctly handles such devices). > > > > > > This is needed for Insignal's Exynos4412 based Origen board. > > > > > > Cc: Krzysztof Kozlowski <[email protected]> > > > Cc: Sangbeom Kim <[email protected]> > > > Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]> > > > Acked-by: Kyungmin Park <[email protected]> > > > --- > > > patch is against next-20140804 branch of linux-next kernel > > > > > > drivers/mfd/sec-irq.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > Looks and works good (tested on board with S2MPS14). > > Reviewed-by: Krzysztof Kozlowski <[email protected]> > Tested-by: Krzysztof Kozlowski <[email protected]> > > Best regards, > Krzysztof > > > > > > > diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c > > > index f9a5786..b65a7f0 100644 > > > --- a/drivers/mfd/sec-irq.c > > > +++ b/drivers/mfd/sec-irq.c > > > @@ -478,5 +478,6 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) > > > > > > void sec_irq_exit(struct sec_pmic_dev *sec_pmic) > > > { > > > - regmap_del_irq_chip(sec_pmic->irq, sec_pmic->irq_data); > > > + if (sec_pmic->irq) > > > + regmap_del_irq_chip(sec_pmic->irq, sec_pmic->irq_data); > > > }
Seems I jumped too far with this one. Patch looks OK and works fine but is it really needed? If (!sec_pmic->irq) then sec_pmic->irq_data will be NULL and regmap_del_irq_chip() will handle it correctly. Your change adds some sense of precautions (the sec_pmic->irq_data may be set by some other module by mistake) but still it does not look like "needed" for Origen. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
