On 08/09, Cyrill Gorcunov wrote: > > On Fri, Aug 08, 2014 at 08:57:47PM +0200, Oleg Nesterov wrote: > ... > > +++ b/fs/proc/inode.c > > @@ -73,6 +73,7 @@ static struct inode *proc_alloc_inode(struct super_block > > *sb) > > ei->pde = NULL; > > ei->sysctl = NULL; > > ei->sysctl_entry = NULL; > > + ei->pid_entry = NULL; > > ei->ns.ns = NULL; > > ei->ns.ns_ops = NULL; > > inode = &ei->vfs_inode; > > Hi Oleg, sorry for not responding to previous emails, will try to review this > things tomorrow (from a glance looks quite good!). Btw, this moment strike my > eyes -- why don't we use kmem_cache_zalloc here but do assign nils again and > again, maybe worth to address as well?
Probably because this doesn't make sense to nullify proc_inode->vfs_inode, it will be reinitialized at least by inode_init_always() anyway. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
