On Aug 9, 2014, at 4:40 PM, Rickard Strandqvist <[email protected]> wrote:
> Added a guaranteed null-terminate after call to strncpy. > > Signed-off-by: Rickard Strandqvist <[email protected]> > --- > drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > index f3d5d79..de327b6 100644 > --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c > @@ -574,6 +574,7 @@ myri10ge_validate_firmware(struct myri10ge_priv *mgp, > > /* save firmware version for ethtool */ > strncpy(mgp->fw_version, hdr->version, sizeof(mgp->fw_version)); > + mgp->fw_version[sizeif(mgp->fw_version) - 1] = '\0'; Surely you meant sizeof above. Did you really not even compile this? > sscanf(mgp->fw_version, "%d.%d.%d", &mgp->fw_ver_major, > &mgp->fw_ver_minor, &mgp->fw_ver_tiny); -- Mark Rustad, [email protected]
signature.asc
Description: Message signed with OpenPGP using GPGMail
