On Tue, Aug 12, 2014 at 01:29:28PM +0800, Baoquan He wrote:
> Add a check if crashk_res_low exists just like GART region does. If
> crashk_res_low doesn't exist, calling exclude_mem_range is unnecessary.
>
> Meanwhile, since crashk_res_low has been initialized at definition, it's
> safe just use "if (crashk_low_res.end)" to check if it's exist. And this
> can make it consistent with other places of check.
>
> Signed-off-by: Baoquan He <b...@redhat.com>
This patch looks good.
Acked-by: Vivek Goyal <vgo...@redhat.com>
Vivek
> ---
> arch/x86/kernel/crash.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> index 0553a34..c9e83f9 100644
> --- a/arch/x86/kernel/crash.c
> +++ b/arch/x86/kernel/crash.c
> @@ -238,7 +238,7 @@ static void fill_up_crash_elf_data(struct crash_elf_data
> *ced,
> ced->max_nr_ranges++;
>
> /* If crashk_low_res is not 0, another range split possible */
> - if (crashk_low_res.end != 0)
> + if (crashk_low_res.end)
> ced->max_nr_ranges++;
> }
>
> @@ -336,9 +336,11 @@ static int elf_header_exclude_ranges(struct
> crash_elf_data *ced,
> if (ret)
> return ret;
>
> - ret = exclude_mem_range(cmem, crashk_low_res.start, crashk_low_res.end);
> - if (ret)
> - return ret;
> + if (crashk_low_res.end) {
> + ret = exclude_mem_range(cmem, crashk_low_res.start,
> crashk_low_res.end);
> + if (ret)
> + return ret;
> + }
>
> /* Exclude GART region */
> if (ced->gart_end) {
> --
> 1.8.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
