On Wed, 2014-08-13 at 14:46 +0530, Himangi Saraogi wrote:
> Continue is not needed at the bottom of a loop.
>
> The Coccinelle semantic patch implementing this change is:
>
> @@
> @@
>
> for (...;...;...) {
> ...
> if (...) {
> ...
> - continue;
> }
> }
>
> Signed-off-by: Himangi Saraogi <himangi...@gmail.com>
> Acked-by: Julia Lawall <julia.law...@lip6.fr>
> ---
> net/ipv4/udp_offload.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c
> index 59035bc..62d5b9b 100644
> --- a/net/ipv4/udp_offload.c
> +++ b/net/ipv4/udp_offload.c
> @@ -269,10 +269,8 @@ unflush:
> continue;
>
> uh2 = (struct udphdr *)(p->data + off);
> - if ((*(u32 *)&uh->source != *(u32 *)&uh2->source)) {
> + if ((*(u32 *)&uh->source != *(u32 *)&uh2->source))
> NAPI_GRO_CB(p)->same_flow = 0;
> - continue;
> - }
> }
>
> skb_gro_pull(skb, sizeof(struct udphdr)); /* pull encapsulating udp
> header */
Please do not do that.
If we add another check later, we'll miss that the 'continue;' needs to
be put back.
GRO stack is quite difficult to maintain, I prefer we keep this as is
for consistency and code readability.
Every time we clear same_flow, we use the "continue;" construct.
if (...) {
NAPI_GRO_CB(p)->same_flow = 0;
continue;
}
<here we can eventually add some other check>
Compiler generates the same code anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
