On Tue, Aug 19, 2014 at 01:30:28PM +0300, Mathias Nyman wrote:
> It appears that input sensing bit might be reset during
> suspend/resume. Set input sensing again for all requested gpios
> in resume
>
> Tested-by: Jerome Blin <[email protected]>
> Signed-off-by: Mathias Nyman <[email protected]>
> ---
> drivers/gpio/gpio-lynxpoint.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
> index ff9eb91..4165672 100644
> --- a/drivers/gpio/gpio-lynxpoint.c
> +++ b/drivers/gpio/gpio-lynxpoint.c
> @@ -407,9 +407,33 @@ static int lp_gpio_runtime_resume(struct device *dev)
> return 0;
> }
>
> +static int lp_gpio_suspend(struct device *dev)
> +{
> + return 0;
> +}
If this function doesn't do anything why it needs to be defined here?
> +
> +static int lp_gpio_resume(struct device *dev)
> +{
> + struct platform_device *pdev = to_platform_device(dev);
> + struct lp_gpio *lg = platform_get_drvdata(pdev);
> + unsigned long reg;
> + int i;
> +
> + /* on some hardware suspend clears input sensing, re-enable it here */
> + for (i = 0; i < lg->chip.ngpio; i++) {
> + if (gpiochip_is_requested(&lg->chip, i) != NULL) {
> + reg = lp_gpio_reg(&lg->chip, i, LP_CONFIG2);
> + outl(inl(reg) & ~GPINDIS_BIT, reg);
> + }
> + }
> + return 0;
> +}
> +
> static const struct dev_pm_ops lp_gpio_pm_ops = {
> .runtime_suspend = lp_gpio_runtime_suspend,
> .runtime_resume = lp_gpio_runtime_resume,
> + .suspend = lp_gpio_suspend,
> + .resume = lp_gpio_resume,
> };
>
> static const struct acpi_device_id lynxpoint_gpio_acpi_match[] = {
> --
> 1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
