David S. Miller <mailto:[EMAIL PROTECTED]> wrote on Saturday, March 19, 2005 4:27 PM:
> On Sat, 19 Mar 2005 12:30:05 -0800 > David Mosberger <[EMAIL PROTECTED]> wrote: > >> I agree about your concern about cost. Accessing the page_map is >> expensive (integer division + memory access) and we have to do that >> in order to find out if the page is i-cache clean. > > First, it's a multiply by reciprocol. At least on sparc64 I get > this emitted by the compiler. > > Secondly, if you're willing to sacrifice 8 bytes per page struct > simply define WANT_PAGE_VIRTUAL and page struct will be exactly > 64 bytes and thus the divide a will turn into a simple shift. As said earlier, set_pte_at is getting called from different places. Not all of these times, we are actually installing valid page entries in page tables. Validating the incoming entry for all of these scenarois (or changing page struct) is an extra overhead that should be avoided...besides being less palatable as compared to new API. The recent changes in interfaces, because of set_pte_at, does provide an opportunity though to handle mprotect issue little differently. We could call update_mmu_cache after setting the new protections in change_pte_range function.....similar to the way update_mmu_cache gets called at fault and any other times......though for this solution, we need to extend change_pte_range interface to have vma parameter as well. -rohit - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
