On Thu, 2014-08-21 at 23:37 +0200, Joerg Roedel wrote: > From: Joerg Roedel <[email protected]> > > Checking adev == NULL is not sufficient as > acpi_bus_get_device() might not touch the value of this > parameter in an error case, so check the return value > directly. > > Fixes: ed40356b5fcf1ce28e026ab39c5b2b6939068b50 > Cc: David Woodhouse <[email protected]> > Signed-off-by: Joerg Roedel <[email protected]> > --- > drivers/iommu/dmar.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 60ab474..06d268a 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -678,8 +678,7 @@ static int __init dmar_acpi_dev_scope_init(void) > andd->device_name); > continue; > } > - acpi_bus_get_device(h, &adev); > - if (!adev) { > + if (acpi_bus_get_device(h, &adev)) { > pr_err("Failed to get device for ACPI object > %s\n", > andd->device_name); > continue;
Reviewed-by: Alex Williamson <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
