ENOSYS means that a nonexistent system call was called. We have a bad habit of using it for things like invalid operations on otherwise valid syscalls. We should avoid this in new code.
Signed-off-by: Andy Lutomirski <l...@amacapital.net> --- Pervasive incorrect usage of ENOSYS came up at the kernel summit ABI review discussion. Let's see if checkpatch can help. scripts/checkpatch.pl | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 182be0f..5749a44 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2372,6 +2372,15 @@ sub process { "Using $1 is unnecessary\n" . $herecurr); } +# ENOSYS means "bad syscall nr" and nothing else +# (note that this doesn't run on assembly files, so entry*.S is okay) + if ($line =~ /ENOSYS/) { + my $herevet = "$here\n" . cat_vet($line) . "\n"; + ERROR("ENOSYS", + "ENOSYS means 'invalid syscall nr' and nothing else\n" . + " (ignore if this really is syscall entry code)\n" . $herevet); + } + # Check for potential 'bare' types my ($stat, $cond, $line_nr_next, $remain_next, $off_next, $realline_next); -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/