On Fri, 2014-08-22 at 23:53 +0200, Christian Lamparter wrote: > The sta_info->agg[tid] check is not needed (for reference, see [0]). > (There is already a check in mac80211 which prevents the leak of > sta_info->agg[tid] [1]). > > Regards > Christian > > [0] <https://lkml.org/lkml/2014/8/20/725> > [1] <http://lxr.free-electrons.com/source/net/mac80211/agg-tx.c#L583> >
Hmpfff... this code is quite confusing. RCU is used both in tricky way (carl9170_ampdu_gc() is an example) and a talisman (the part you remove) Why is rcu_assign_pointer(sta_info->agg[tid], tid_info); done inside the spinlock protected region, I don't know. If this code relies on external protection, a comment would help its comprehension for sure. For example, you could add a BUG_ON(rcu_access_pointer(sta_info->agg[tid])); so that we are sure requirements are not changed in the callers one day. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
