On Mon, 25 Aug 2014 21:37:08 +0200, John Spencer wrote: > From 4a72032828a6784d93f4becf723303a17d723544 Mon Sep 17 00:00:00 2001 > From: John Spencer <maillist-li...@barfooze.de> > Date: Mon, 25 Aug 2014 21:25:43 +0200 > Subject: [PATCH 2/2] perf Makefile: default WERROR to off. > > Having WERROR on by default breaks build everywhere the author hasn't > tested so far; including musl libc which warns about wrong includes. > > The unsuspecting user will think there's something broken and only > if he's coureageuous enough to grep the Makefile infrastructure find > out that he may be able to get the build working with WERROR=0. > > OTOH with WERROR defaulting to off, anything will work for the user > and the maintainer can knowingly use WERROR=1 to do his test builds.
I think it's intentionally turned on to fix any warnings in the first place. But yes, it might miss some non-popular systems tho.. How many errors/warnings do you see on your system (musl libc?). Any chance to post fixes instead? Thanks, Namhyung > > Signed-off-by: John Spencer <maillist-li...@barfooze.de> > > --- > tools/perf/config/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile > index 1f67aa0..b1d639a 100644 > --- a/tools/perf/config/Makefile > +++ b/tools/perf/config/Makefile > @@ -102,7 +102,7 @@ ifeq ($(call get-executable,$(BISON)),) > endif > > # Treat warnings as errors unless directed not to > -ifneq ($(WERROR),0) > +ifeq ($(WERROR),1) > CFLAGS += -Werror > endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/