On Mon, Aug 25, 2014 at 02:52:55PM -0600, Keith Busch wrote: > Since the partition's release may be invoked from call_rcu's soft-irq > context, the ext_dev_idr's mutex had to be replaced with a spinlock so > as not so sleep.
> @@ -420,9 +420,9 @@ int blk_alloc_devt(struct hd_struct *part, dev_t *devt) > } > > /* allocate ext devt */ > - mutex_lock(&ext_devt_mutex); > + spin_lock(&ext_devt_lock); > idx = idr_alloc(&ext_devt_idr, part, 0, NR_EXT_DEVT, GFP_KERNEL); > - mutex_unlock(&ext_devt_mutex); > + spin_unlock(&ext_devt_lock); Can't use GFP_KERNEL if we're protected with a spinlock. See the comment in lib/idr.c about idr_preload: + idr_preload(GFP_KERNEL); - mutex_lock(&ext_devt_mutex); + spin_lock(&ext_devt_lock); - idx = idr_alloc(&ext_devt_idr, part, 0, NR_EXT_DEVT, GFP_KERNEL); + idx = idr_alloc(&ext_devt_idr, part, 0, NR_EXT_DEVT, GFP_NOWAIT); - mutex_unlock(&ext_devt_mutex); + spin_unlock(&ext_devt_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
