Hi,
On Tue, Aug 26, 2014 at 06:22:40PM +0800, Peter Chen wrote:
> On Fri, Aug 22, 2014 at 05:50:19PM +0200, Antoine Ténart wrote:
>
> If the common usb_otg and usb_phy struct still has another's pointer, you
> may not need to add this patch.
Except if we want to access the OTG member when not using an USB PHY.
> > diff --git a/drivers/usb/chipidea/host.c b/drivers/usb/chipidea/host.c
> > index 0b67d78dd953..0952d4adfa4c 100644
> > --- a/drivers/usb/chipidea/host.c
> > +++ b/drivers/usb/chipidea/host.c
> > @@ -85,13 +85,11 @@ static int host_start(struct ci_hdrc *ci)
> > if (ret) {
> > goto disable_reg;
> > } else {
> > - struct usb_otg *otg = ci->usb_phy->otg;
> > + struct usb_otg *otg = &ci->otg;
> >
> > ci->hcd = hcd;
> > - if (otg) {
> > - otg->host = &hcd->self;
> > - hcd->self.otg_port = 1;
> > - }
> > + otg->host = &hcd->self;
> > + hcd->self.otg_port = 1;
> > }
>
> You may need use other way to identify if otg is supported or not
How would you do that?
> > - otg->usb_phy = ci->usb_phy;
> > - otg->gadget = &ci->gadget;
> > - ci->fsm.otg = otg;
> > - ci->usb_phy->otg = ci->fsm.otg;
> > + ci->otg.usb_phy = ci->usb_phy;
> > + ci->fsm.otg = &ci->otg;
> > ci->fsm.power_up = 1;
> > ci->fsm.id = hw_read_otgsc(ci, OTGSC_ID) ? 1 : 0;
> > ci->fsm.otg->state = OTG_STATE_UNDEFINED;
>
> Why otg->gadget and ci->usb_phy->otg initialization are deleted?
> At least, the parameters of usb_otg_state_string at your 7th patch uses it.
Sure, I'll fix this
Antoine
--
Antoine Ténart, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
