On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote: > Replace a long list of contiguous writel() calls with a for loop iterating > over the same values. > > Signed-off-by: Mark Einon <mark.ei...@gmail.com> > --- > drivers/staging/et131x/et131x.c | 27 +++------------------------ > 1 file changed, 3 insertions(+), 24 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c > index fffe763..44cc684 100644 > --- a/drivers/staging/et131x/et131x.c > +++ b/drivers/staging/et131x/et131x.c > @@ -1138,6 +1138,7 @@ static void et1310_config_rxmac_regs(struct > et131x_adapter *adapter) > u32 sa_lo; > u32 sa_hi = 0; > u32 pf_ctrl = 0; > + u32 *wolw; > > /* Disable the MAC while it is being configured (also disable WOL) */ > writel(0x8, &rxmac->ctrl); > @@ -1151,30 +1152,8 @@ static void et1310_config_rxmac_regs(struct > et131x_adapter *adapter) > * its default Values of 0x00000000 because there are not WOL masks > * as of this time. > */ > - writel(0, &rxmac->mask0_word0); > - writel(0, &rxmac->mask0_word1); > - writel(0, &rxmac->mask0_word2); > - writel(0, &rxmac->mask0_word3); > - > - writel(0, &rxmac->mask1_word0); > - writel(0, &rxmac->mask1_word1); > - writel(0, &rxmac->mask1_word2); > - writel(0, &rxmac->mask1_word3); > - > - writel(0, &rxmac->mask2_word0); > - writel(0, &rxmac->mask2_word1); > - writel(0, &rxmac->mask2_word2); > - writel(0, &rxmac->mask2_word3); > - > - writel(0, &rxmac->mask3_word0); > - writel(0, &rxmac->mask3_word1); > - writel(0, &rxmac->mask3_word2); > - writel(0, &rxmac->mask3_word3); > - > - writel(0, &rxmac->mask4_word0); > - writel(0, &rxmac->mask4_word1); > - writel(0, &rxmac->mask4_word2); > - writel(0, &rxmac->mask4_word3); > + for (wolw = &rxmac->mask0_word0; wolw <= &rxmac->mask4_word3; wolw++) > + writel(0, wolw);
You are now only writing to all locations 1 time, instead of 4 times, like before, are you sure that is ok? Hardware is flaky, sometimes it wants to be written to multiple times... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
