On Mon, Aug 25, 2014 at 12:03:11PM +0300, Andy Shevchenko wrote: > The new seq_hex_dump() is a complete analogue of print_hex_dump(). > > We have few users of this functionality already. It allows to reduce their > codebase.
I really don't like the stack footprint. > + unsigned char linebuf[32 * 3 + 2 + 32 + 1]; ... and extra copying for no good reason. Why not check that we have enough space in buffer and generate directly into it? See what e.g. seq_escape() is doing... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
