> > > > I don't understand the reason for adding dwapb_read and dwapb_write here. > > The rest of the driver is using readl and writel. I'd rather not see > > two different methods being used in the same driver for register access. > > Maybe I'm missing something, but if we need to add dwapb_read/write, > > then it should be used for all register access. > > Alan, it was my proposal. I rather agree that is better to convert all > accesses to > that. OK, I will convert all readl&writel to dwapb_read&dwapb_write.
