On Mon, 2014-09-01 at 15:13 +0300, Dan Carpenter wrote: > Pretty nice. This is very special purpose hardware and the UAPI for > this is fine. The documentation seems good. I had some minor style > comments but nothing major stands out. > > These days I quite like the --strict option for checkpatch.pl. > > for i in $(find drivers/staging/xillybus/ -name \*\.c) > do ./scripts/checkpatch.pl --strict -f $i > done
Maybe --strict should be on by default for staging like it is for drivers/net and net? --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d89857d..90199a7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2016,7 +2016,7 @@ sub process { } if ($found_file) { - if ($realfile =~ m@^(drivers/net/|net/)@) { + if ($realfile =~ m@^(drivers/net/|net/|drivers/staging/)@) { $check = 1; } else { $check = $check_orig; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/