On Sep 01 Sander Nemvalts wrote: > --- a/drivers/firewire/core-card.c > +++ b/drivers/firewire/core-card.c > @@ -89,7 +89,8 @@ static size_t config_rom_length = 1 + 4 + 1 + 1; > #define BIB_ISC ((1) << 29) > #define BIB_CMC ((1) << 30) > #define BIB_IRMC ((1) << 31) > -#define NODE_CAPABILITIES 0x0c0083c0 /* per IEEE 1394 clause 8.3.2.6.5.2 > */ > +/* per IEEE 1394 clause 8.3.2.6.5.2 */ > +#define NODE_CAPABILITIES 0x0c0083c0
This is no improvement. > /* > * IEEE-1394 specifies a default SPLIT_TIMEOUT value of 800 cycles (100 ms), > @@ -132,7 +133,7 @@ static void generate_config_rom(struct fw_card *card, > __be32 *config_rom) > j = 7 + descriptor_count; > > /* Generate root directory entries for descriptors. */ > - list_for_each_entry (desc, &descriptor_list, link) { > + list_for_each_entry(desc, &descriptor_list, link) { > if (desc->immediate > 0) > config_rom[i++] = cpu_to_be32(desc->immediate); > config_rom[i] = cpu_to_be32(desc->key | (j - i)); We are writing for (a; b; c); not for(a; b; c); and thus a space after list_for_each and friends makes sense. -- Stefan Richter -=====-====- =--= ----= http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/