On Tue, 02 Sep 2014, Chang, Rebecca Swee Fun wrote: > > > > -----Original Message----- > > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > > Sent: 01 September, 2014 6:25 PM > > To: Lee Jones > > Cc: Bjorn Helgaas; linux-kernel@vger.kernel.org; Samuel Ortiz; Chang, > > Rebecca > > Swee Fun > > Subject: Re: [PATCH v1 2/5] mfd: lpc_sch: better code manageability with > > chipset info struct > > > > On Mon, 2014-09-01 at 10:16 +0100, Lee Jones wrote: > > > On Fri, 22 Aug 2014, Andy Shevchenko wrote: > > > > > > > Introduce additional struct to hold chipset info. This chipset info > > > > will be used to store features that are supported by specific > > > > processor or chipset. LPC_SCH supports SMBUS, GPIO and WDT features. > > > > As this code base might expand further to support more processors, > > > > this implementation will help to keep code base clean and manageable. > > > > > > > > Signed-off-by: Chang Rebecca Swee Fun > > > > <rebecca.swee.fun.ch...@intel.com> > > > > Tested-by: Chang Rebecca Swee Fun <rebecca.swee.fun.ch...@intel.com> > > > > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > > > [] > > > > > > > The first patch would look a great deal cleaner if it had these > > > changes in too. Unless you have a really good reason not to, please > > > consider squashing them. > > > > The only reason behind is that this patch (in other form) was written by > > Rebecca in the first place. I recommended to clean up before, and actually > > did > > that clean up and amended Rebecca's patch. > > > > So, if Rebecca has now objections I could squash it. > > I have no objections. Thanks.
Thanks Rebecca. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
