On 09/02, Jiri Kosina wrote: > > On Tue, 2 Sep 2014, Vishnu Pratap Singh wrote: > > > From: "vishnu.ps" <[email protected]> > > > > Fix minor errors and warning messages in kernel/signal.c. These errors were > > reported by checkpatch while working with some modifications in signal.c > > file. > > > > ERROR: code indent should use tabs where possible - 18 > > ERROR: need consistent spacing around '&' (ctx:WxO) - 11 > > ERROR: space prohibited after that '~' (ctx:OxW) - 11 > > ERROR: trailing whitespace - 4 > > ERROR: space required after that ',' (ctx:VxV) - 4 > > ERROR: trailing statements should be on next line - 3 > > ERROR: "foo * bar" should be "foo *bar" - 1 > > > > total 52 errors fixed. > > I am not taking this through trivial.git; it just clutters results of 'git > blame' horribly for no measurable gain. > > Changes like this are reasonable only if you make any real changes to the > code at the same time.
I agree very much. Vishnu, please think about those (me in particular ;) who need to backport the fixes from time to time. Just suppose we have a bug in, say, do_notify_parent_cldstop(), and it is fixed later. Now I will likely need to backport your change too, and this is not trivial in general, plus this adds the additional risk. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
