On Tue, Sep 02, 2014 at 06:22:07PM +0100, Sudeep Holla wrote: > Hi Greg, > > On 22/08/14 12:29, Sudeep Holla wrote: > >From: Sudeep Holla <sudeep.ho...@arm.com> > > > >This patch adds a new function to create per-cpu devices. > >This helps in: > >1. reusing the device infrastructure to create any cpu related > > attributes and corresponding sysfs instead of creating and > > dealing with raw kobjects directly > >2. retaining the legacy path(/sys/devices/system/cpu/..) to support > > existing sysfs ABI > >3. avoiding to create links in the bus directory pointing to the > > device as there would be per-cpu instance of these devices with > > the same name since dev->bus is not populated to cpu_sysbus on > > purpose > > > >Signed-off-by: Sudeep Holla <sudeep.ho...@arm.com> > >Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > >--- > > drivers/base/cpu.c | 54 > > +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > include/linux/cpu.h | 4 ++++ > > 2 files changed, 58 insertions(+) > > > >Hi Greg, > > > >Here is the alternate solution I could come up with instead of > >creating cpu class. cpu_device_create is very similar to > >device_create_groups_vargs w/o class support, but I could not > >reuse anything else to avoid creating similar function. > > > >Let me know your thoughts/suggestions on this. > > > > Any feedback on this ? If ok, I will respin cacheinfo series removing > cpu class creation with this patch.
Please address the issues others have already raised. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
