From: Mark Rustad <[email protected]>

Resolve a shadow warning in W=2 builds arising from min/max macro
references in a parameter to a min3/max3 macro. There is no
functional issue - the warning is benign - but simply changing
some local variable names will eliminate it.

Signed-off-by: Mark Rustad <[email protected]>
Signed-off-by: Jeff Kirsher <[email protected]>
---
 include/linux/kernel.h | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 95624be..c653902 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -716,22 +716,22 @@ static inline void ftrace_dump(enum ftrace_dump_mode 
oops_dump_mode) { }
        _max1 > _max2 ? _max1 : _max2; })
 
 #define min3(x, y, z) ({                       \
-       typeof(x) _min1 = (x);                  \
-       typeof(y) _min2 = (y);                  \
-       typeof(z) _min3 = (z);                  \
-       (void) (&_min1 == &_min2);              \
-       (void) (&_min1 == &_min3);              \
-       _min1 < _min2 ? (_min1 < _min3 ? _min1 : _min3) : \
-               (_min2 < _min3 ? _min2 : _min3); })
+       typeof(x) _min31 = (x);                 \
+       typeof(y) _min32 = (y);                 \
+       typeof(z) _min33 = (z);                 \
+       (void) (&_min31 == &_min32);            \
+       (void) (&_min31 == &_min33);            \
+       _min31 < _min32 ? (_min31 < _min33 ? _min31 : _min33) : \
+               (_min32 < _min33 ? _min32 : _min33); })
 
 #define max3(x, y, z) ({                       \
-       typeof(x) _max1 = (x);                  \
-       typeof(y) _max2 = (y);                  \
-       typeof(z) _max3 = (z);                  \
-       (void) (&_max1 == &_max2);              \
-       (void) (&_max1 == &_max3);              \
-       _max1 > _max2 ? (_max1 > _max3 ? _max1 : _max3) : \
-               (_max2 > _max3 ? _max2 : _max3); })
+       typeof(x) _max31 = (x);                 \
+       typeof(y) _max32 = (y);                 \
+       typeof(z) _max33 = (z);                 \
+       (void) (&_max31 == &_max32);            \
+       (void) (&_max31 == &_max33);            \
+       _max31 > _max32 ? (_max31 > _max33 ? _max31 : _max33) : \
+               (_max32 > _max33 ? _max32 : _max33); })
 
 /**
  * min_not_zero - return the minimum that is _not_ zero, unless both are zero
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to