On Wednesday 23 March 2005 00:55, Jesper Juhl wrote:
>
> Remove a redundant NULL pointer check prior to kfree(). kfree() has no
> problem with NULL pointers.
>
>
> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
>
> --- linux-2.6.12-rc1-mm1-orig/fs/devfs/base.c 2005-03-02 08:37:49.000000000
> +0100
> +++ linux-2.6.12-rc1-mm1/fs/devfs/base.c 2005-03-22 23:51:23.000000000
> +0100
> @@ -2738,10 +2738,8 @@ static int devfsd_close(struct inode *in
> entry = fs_info->devfsd_first_event;
> fs_info->devfsd_first_event = NULL;
> fs_info->devfsd_last_event = NULL;
> - if (fs_info->devfsd_info) {
> - kfree(fs_info->devfsd_info);
> - fs_info->devfsd_info = NULL;
> - }
> + kfree(fs_info->devfsd_info);
> + fs_info->devfsd_info = NULL;
> spin_unlock(&fs_info->devfsd_buffer_lock);
> fs_info->devfsd_pgrp = 0;
> fs_info->devfsd_task = NULL;
IIRC devfs is deprecated and has less than a year to live.
--
vda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
