On Thu, 2014-09-04 at 11:23 -0700, Vadim Bendebury wrote:
> This script is used by many other projects, and in some of them the
> requirement of at least 4 line long description for all Kconfig items
> is excessive. This patch adds a command line option to control the
> required minimum length.
>
> Tested running this script over a patch including a two line config
> description. The script generated a warning when invoked as is, and
> did not generate it when invoked with --min-conf-desc-length=2.
>
> Signed-off-by: Vadim Bendebury <vben...@chromium.org>
> ---
>
> Changes in v2:
> - modified the condition check as requested
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2280,8 +2283,10 @@ sub process {
> }
> $length++;
> }
> - WARN("CONFIG_DESCRIPTION",
> - "please write a paragraph that describes the
> config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
> + if ($is_start && $is_end && $length <
> $min_conf_desc_length) {
> + WARN("CONFIG_DESCRIPTION",
> + "please write a paragraph that describes the
> config symbol fully\n" . $herecurr)
> + }
> #print "is_start<$is_start> is_end<$is_end>
> length<$length>\n";
> }
>
Thank you but this is not quite right.
checkpatch uses tabs for indentation.
You've used 4 spaces for the WARN.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
