Hello,
On Thu, Sep 04, 2014 at 03:30:41PM -0700, Cong Wang wrote:
...
> Cc: David Rientjes <rient...@google.com>
> Cc: Michal Hocko <mho...@suse.cz>
> Cc: "Rafael J. Wysocki" <r...@rjwysocki.net>
> Cc: Tejun Heo <t...@kernel.org>
> Cc: Andrew Morton <a...@linux-foundation.org>
> Acked-by: Michal Hocko <mho...@suse.cz>
> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Prolly should sta...@vger.kernel.org?
> +static bool should_thaw_current(bool check_kthr_stop)
> +{
> + if (!freezing(current))
> + return true;
> +
> + if (check_kthr_stop && kthread_should_stop())
> + return true;
> +
> + /* It might not be safe to check TIF_MEMDIE for pm freeze. */
This is just another representation of the following code which isn't
particularly useful. Wouldn't it be better if the comment actually
explains why this might not be safe?
> + if (cgroup_freezing(current) && test_thread_flag(TIF_MEMDIE))
> + return true;
> +
> + return false;
> +}
Other than that,
Acked-by: Tejun Heo <t...@kernel.org>
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
