On Tue, 2014-09-09 at 23:16 +0000, Anish Bhatt wrote: > > It would be really good if SCSI_NETLINK depended on NET instead of selected > > NET. > > We shouldn't have kconfig symbols that use 'select' on entire subsystems. > > As a test, I was able to fix this by this approach : change SCSI_NETLINK to > depend > on NET instead of selecting NET, and replacing 'select NETDEVICES ETHERNET > NET_VENDOR_BROADCOM CNIC' to 'depends on CNIC' in bnx2i & bnx2fc. (as CNIC > already has a dependency on those). This removes the need to check for IPV6 > in > bnx2i/fc Kconfigs as well. > > The side effect is that you won't see BNX2 drivers unless CNIC is selected, > similar > for SCSI_NETLINK as well, not sure if there are any other implications.
Right. I think it is more user-friendly for BNX2I and BNX2FC to select CNIC. CNIC is not useful by itself and it makes more sense to select it automatically when BNX2I/BNX2FC are enabled. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
