On Wed, Sep 10, 2014 at 01:55:31PM -0400, [email protected] wrote:
SNIP
> + struct perf_pmu_event_symbol *pmu2 =
> + (struct perf_pmu_event_symbol *) p2;
> +
> + return strcmp(pmu1->symbol, pmu2->symbol);
> +}
> +
> +/*
> + * Read the pmu events list from sysfs
> + * Save it into perf_pmu_events_list
> + */
> +static void perf_pmu__parse_init(void)
> +{
> +
> + struct perf_pmu *pmu = NULL;
> + struct perf_pmu_alias *alias;
> + int len = 0;
> +
> + while ((pmu = perf_pmu__scan(pmu)) != NULL)
> + list_for_each_entry(alias, &pmu->aliases, list) {
> + if (!strcmp(pmu->name, "cpu")) {
> + if (strchr(alias->name, '-'))
> + len++;
> + len++;
> + }
> + }
> + if (len == 0)
> + return;
s oif 'len' is 0 we will scan all the time? maybe we want some
separate 'init' variable..
> + perf_pmu_events_list =
> + malloc(sizeof(struct perf_pmu_event_symbol) * len);
> + perf_pmu_events_list_num = len;
> +
> + pmu = NULL;
> + len = 0;
SNIP
> + qsort(perf_pmu_events_list, len,
> + sizeof(struct perf_pmu_event_symbol), comp_pmu);
> +
> +}
> +
> +static void perf_pmu__parse_cleanup(void)
> +{
> + if (!perf_pmu_events_list_num) {
should this be 'if (perf_pmu_events_list_num)' ?
could you also please write automated test for this feature?
thanks,
jirka
> + struct perf_pmu_event_symbol *p;
> + size_t i;
> +
> + for (i = 0; i < perf_pmu_events_list_num; i++) {
> + p = perf_pmu_events_list + i;
> + free(p->symbol);
> + }
> + free(perf_pmu_events_list);
> + perf_pmu_events_list = NULL;
> + perf_pmu_events_list_num = 0;
> + }
> +}
> +
SNIP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
