On Thu, 11 Sep 2014, Chen, Alvin wrote: > > > > > > Hi Alvin, > > > > > > I did a quick test and this looks like it works for me (with device tree). > > > I had a couple of small fixes below. > > It is very appreciated to help testing.
Sure. Thanks for adding features to the driver! > > > > > > > Alan > > > > > > > > > > > - port->bgc.gc.ngpio = ngpio; > > > > - port->bgc.gc.of_node = port_np; > > > > +#ifdef CONFIG_OF_GPIO > > > > + port->bgc.gc.of_node = pp->node; > > > > +#endif > > > > > > Please use 'if (IS_ENABLED(CONFIG_OF_GPIO)) as a conditional as you do > > > elsewhere. > > OK. > > > Alan, I just do a quick test, here we can't use 'IS_ENABLED', it can't be > compiled without OF_GPIO set. > Because 'gc.of_node' is not defined without 'OF_GPIO'. You can refer the > structure of 'gc'. > That makes sense. Thanks, Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
