Dear Boris BREZILLON, On Thu, 11 Sep 2014 17:38:54 +0200, Boris BREZILLON wrote:
> > Anyway, with or without the docs I think this patch breaks DT backward > > compatibility. > > > > Or am I missing something? > > Indeed, this block of code should be placed at the end of the probe > function. I'll fix that. > > Note that if the clk is missing it just print a warning message and > return 0, so after moving the code, it should not break DT backward > compat ;-). You may want to use: dev_warn(FW_WARN "NFC clock missing, update your Device Tree\n"); Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/