Axel, On Thu, Sep 11, 2014 at 3:22 AM, Axel Lin <axel....@ingics.com> wrote: > 1. Pass &pdev->dev rather than &client->dev to of_regulator_match, the *dev > argument is used for devres to ensure devm_of_regulator_put_matches() will > be called when unload the module. > > 2. of_get_child_by_name() returns a node pointer with refcount incremented. > Thus add missing of_node_put(reg_np). > > Signed-off-by: Axel Lin <axel....@ingics.com> > --- > drivers/regulator/rk808-regulator.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
I've tested that things still work fine after applying this patch and confirmed both of your statements are true to the best of my knowledge. I haven't tested module removal (which is where some of this matters) but what's here looks good. Reviewed-by: Doug Anderson <diand...@chromium.org> Tested-by: Doug Anderson <diand...@chromium.org> -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
