Hi On Sat, Sep 13, 2014 at 11:13:53PM +0200, Peter Hüwe wrote: > Hi > > > Am Samstag, 13. September 2014, 19:35:33 schrieb Jarkko Sakkinen: > > Replaced transmit_cmd() functions in tpm-interface.c and tpm-sysfs.c > > with a single tpm_transmit_cmd() that can be used in both files. > > > > This patch is preliminary clean up work for the TPM2 support. This > > function is needed for implementing TPM2 versions of the in-kernel > > TPM utility functions. > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> > > why the renaming?
Because all the other non-static functions have tpm_ prefix. > > > > ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf, > > size_t bufsiz); > Can this be removed then? Yes, it could be declared as a static function in tpm-interface.c and removed from tpm.h. I'll make this change and send a revised patch. > > +ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_cmd_t *cmd, > > + int len, const char *desc); > > extern int tpm_get_timeouts(struct tpm_chip *); > > extern void tpm_gen_interrupt(struct tpm_chip *); > > extern int tpm_do_selftest(struct tpm_chip *); > > > > Peter /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
