On 09/16/2014 12:04 PM, Geert Uytterhoeven wrote: > Hi Michal, > > On Tue, Sep 16, 2014 at 11:23 AM, Michal Simek <mon...@monstr.eu> wrote: >> On 09/14/2014 11:02 AM, Chen Gang wrote: >>> On 09/14/2014 04:45 PM, Geert Uytterhoeven wrote: >>>> Hi Chen, >>>> >>>> On Sun, Sep 14, 2014 at 10:32 AM, Chen Gang <gang.chen.5...@gmail.com> >>>> wrote: >>>>> Add default one just like other architectures have done (e.g. cris, >>>>> score, sh ...), the related error with allmodconfig: >>>>> >>>>> LD init/built-in.o >>>>> drivers/built-in.o: In function `vgacon_save_screen': >>>>> drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined >>>>> reference to `screen_info' >>>>> drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined >>>>> reference to `screen_info' >>>>> drivers/built-in.o: In function `vgacon_resize': >>>>> drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined >>>>> reference to `screen_info' >>>>> drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined >>>>> reference to `screen_info' >>>>> drivers/built-in.o: In function `vgacon_switch': >>>>> drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined >>>>> reference to `screen_info' >>>>> drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): >>>>> more undefined references to `screen_info' follow >>>>> make: *** [vmlinux] Error 1 >>>> >>>> Can microblaze actually have VGA? >>>> >>>> If not, it's better to disable it. >>>> >>> >>> Welcome the related microblaze maintainers ideas for it >> >> Is this is just about VGA or video console in general? >> There is xilinx FB driver and other FB are around too. > > These days screen_info is only used by: > - vgacon, > - dummycon on ARM, > - a few fb drivers (efifb, intelfbdrv,sis, vesafb, and vga16fb). > > E.g. m68k doesn't have it.
ok. IRC I think I remember one non mainline FB driver which required it too. It breaks nothing for me that's why no problem to apply it. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
