On Mon, Sep 15, 2014 at 04:56:56PM +0100, Will Deacon wrote: > On Sat, Sep 13, 2014 at 07:31:12PM +0100, Joe Perches wrote: > > Use the more common pr_warn. > > > > Other miscellanea: > > > > o Coalesce formats > > o Realign arguments > > > > Signed-off-by: Joe Perches <j...@perches.com> > > --- > > arch/arm/include/asm/syscall.h | 8 ++++---- > > arch/arm/kernel/atags_parse.c | 2 +- > > arch/arm/kernel/hw_breakpoint.c | 18 +++++++++--------- > > arch/arm/kernel/irq.c | 4 ++-- > > arch/arm/kernel/perf_event_cpu.c | 4 ++-- > > arch/arm/kernel/smp.c | 2 +- > > arch/arm/kernel/unwind.c | 24 ++++++++++++------------ > > arch/arm/mm/idmap.c | 2 +- > > arch/arm/mm/mmu.c | 4 ++-- > > 9 files changed, 34 insertions(+), 34 deletions(-) > > It's Russell's call on this, but it really looks like more trouble than it's > worth imo. Having git blame identify the person who wrote the original code > is considerably more useful than being pointed at somebody making cosmetic > changes.
I have no objection to this patch set, but I'll echo Will's comment that having git blame identify who wrote the code is useful. However, removing old cruft is also a useful exercise, as it keeps things simpler (because we're not carrying around lots of excess baggage.) So, I think on balance it's worth the churn. Joe, any chance you could add a KernelVersion: tag somewhere in the commit message and throw it at patc...@arm.linux.org.uk so it doesn't get lost? Thanks. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/