On 9/12/14, 11:28 AM, Bartlomiej Zolnierkiewicz wrote: > > [ added linux-kernel ML to cc: ] > > Hi, > > On Tuesday, August 26, 2014 11:19:59 AM [email protected] wrote: >> From: Dinh Nguyen <[email protected]> >> >> Since the dwc2 hcd driver is currently not looking for a clock node during >> init, we should not completely fail if there isn't a clock provided. >> Add a check for a valid clock before calling clock functions. > > This doesn't look correct at least for the case when we are really missing > the clock and USB_DWC2_PERIPHERAL=y (moreover it just looks wrong to access > gadget functionalities when clock is disabled). It seems that it would be > better to just disable gadget functionality on dwc2_gadget_init() failure > in hcd and not call gadget functions later from hcd if gadget functionality > is disabled. >
Yes...this is correct. Will fix up in v5. Thanks, Dinh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
