On 09/22/2014 07:07 AM, Eric Auger wrote: > Dear all, > > Thanks Stephen for reporting the problem. Indeed removing irq.h header > file is no more possible since commit > c77dcacb397519b6ade8f08201a4a90a7f4f751e, "KVM: Move more code under > CONFIG_HAVE_KVM_IRQFD" which moves among other things > kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier in > eventfd.c.
Hi, kvm_register_irq_ack_notifier and kvm_unregister_irq_ack_notifier were already included in Paul's patch, commit e4d57e1ee1ab59f0cef0272800ac6c52e0ec814a, KVM: Move irq notifier implementation into eventfd.c and just moved in above patch. So I completely missed this ioapic function. You can remove my commit. No commit does depend on it yet. Thanks Eric > > including virt/kvm/ioapic.h might fix the problem but I am OoO next week > and cannot investigate further right now. > > Please can you remove that commit. Sorry for the inconvenience. > > Best Regards > > Eric > > > On 09/22/2014 06:06 AM, Stephen Rothwell wrote: >> Hi all, >> >> After merging the kvm-arm tree, today's linux-next build (x86_64 >> allmodconfig) >> failed like this: >> >> arch/x86/kvm/../../../virt/kvm/eventfd.c: In function >> 'kvm_register_irq_ack_notifier': >> arch/x86/kvm/../../../virt/kvm/eventfd.c:493:2: error: implicit declaration >> of function 'kvm_vcpu_request_scan_ioapic' >> [-Werror=implicit-function-declaration] >> kvm_vcpu_request_scan_ioapic(kvm); >> ^ >> >> Probably caused by commit 0ba09511ddc3 ("KVM: EVENTFD: remove inclusion >> of irq.h"). >> >> I have used the kvm-arm tree from next-20140919 for today. >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/